From 068b9f8f5dec46b222470f6d3f03244ba5b65f5c Mon Sep 17 00:00:00 2001 From: NymanRobin Date: Thu, 2 May 2024 11:20:01 +0300 Subject: Compare mount by value instead of reference This has to be since the mounts are reloaded each time a mount is added. In case of two mounts mounting at the same time there will be a race condition for applying policy. Signed-off-by: NymanRobin --- filesystem/mountpoint_test.go | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) (limited to 'filesystem') diff --git a/filesystem/mountpoint_test.go b/filesystem/mountpoint_test.go index f06219c..fd7e05d 100644 --- a/filesystem/mountpoint_test.go +++ b/filesystem/mountpoint_test.go @@ -27,6 +27,7 @@ import ( "fmt" "os" "path/filepath" + "reflect" "strings" "testing" ) @@ -544,3 +545,21 @@ func BenchmarkLoadFirst(b *testing.B) { } } } + +// Test mount comparison by values instead of by reference, +// as the map mountsByDevice gets recreated on each load. +// This ensures that concurrent mounts work properly. +func TestMountComparison(t *testing.T) { + var mountinfo = ` +15 0 259:3 / /home rw,relatime shared:1 - ext4 /dev/root rw,data=ordered +` + beginLoadMountInfoTest() + defer endLoadMountInfoTest() + loadMountInfoFromString(mountinfo) + firstMnt := mountForDevice("259:3") + loadMountInfoFromString(mountinfo) + secondMnt := mountForDevice("259:3") + if !reflect.DeepEqual(firstMnt, secondMnt) { + t.Errorf("Mount comparison does not work") + } +} -- cgit v1.2.3