From d6cc933ff1722ca3229aadd8878fe77ba5d05575 Mon Sep 17 00:00:00 2001 From: Eric Biggers Date: Sat, 9 May 2020 14:04:47 -0700 Subject: Wire up shellcheck of cli-tests/*.sh to 'make lint' Enforce that all the cli-test scripts pass 'shellcheck'. --- CONTRIBUTING.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'CONTRIBUTING.md') diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5968d0e..d5be721 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -87,6 +87,7 @@ The `Makefile` will automatically download and build any needed Go dependencies. However, you'll also need to install some non-Go dependencies: - `make format` requires [`clang-format`](https://clang.llvm.org/docs/ClangFormat.html). + - `make lint` requires [`shellcheck`](https://github.com/koalaman/shellcheck). - `make test-setup` and `make cli-test` require [`e2fsprogs`](https://en.wikipedia.org/wiki/E2fsprogs) version 1.43 or later. @@ -96,7 +97,7 @@ However, you'll also need to install some non-Go dependencies: On Ubuntu, the following command installs the needed packages: ``` -sudo apt-get install clang-format e2fsprogs expect keyutils +sudo apt-get install clang-format shellcheck e2fsprogs expect keyutils ``` ### Running Integration Tests -- cgit v1.2.3